• Home
  • About
    • Bio
    • CV
  • Music
    • Shows
    • Works
  • Research
    • Works
  • Programming
    • Projects
  • Blog
    • Watson
    • Viget
  • Contact
    • Message
    • Subscribe
    • Availability

First Pull Request

09 Jun 2016

Reading time ~1 minute

Today I received the first of surely many more onslaughts of in-line GitHub comments on my first pull request ever. Though I pushed close to no actual work at all onto the remote repository, I certainly received a good deal of criticism right off the bat. Specifically, I learned about HTTP status codes by way of attempting to test a controller in my Haxxor News app, which apparently is not the best idea to begin with. Instead, Lawson let me know that I should look into unit and feature testing. Zachary showed me how to configure my application such that the rails generator command no longer annoyingly generates unnecessary assets and helpers, which was dope. Nate and Eli were particularly keen on me deleting said unnecessary files. Finally, Solomon alerted me to the the goodness of replacing stub url values to “TODO”.



Share Tweet +1